Reconstruct blobId by excluding partition Id #2910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SophieGuo410
force-pushed
the
Branch_construct_caspian_blob_name
branch
from
68bba66
to
3c54211
Compare
SophieGuo410
force-pushed
the
Branch_construct_caspian_blob_name
branch
from
3c54211
to
e057d66
Compare
SophieGuo410
requested review from
Arun-LinkedIn,
justinlin-linkedin and
alyssaxu333
| @@ -845,8 +845,8 @@ public RouterConfig(VerifiableProperties verifiableProperties) { | |||
| verifiableProperties.getDoubleInRange(ROUTER_LATENCY_TOLERANCE_QUANTILE, DEFAULT_LATENCY_TOLERANCE_QUANTILE, | |||
| 0.0, 1.0); | |||
| routerBlobidCurrentVersion = | |||
| verifiableProperties.getShortFromAllowedValues(ROUTER_BLOBID_CURRENT_VERSION, (short) 6, | |||
| new Short[]{1, 2, 3, 4, 5, 6}); | |||
| verifiableProperties.getShortFromAllowedValues(ROUTER_BLOBID_CURRENT_VERSION, (short) 7, | |||
There was a problem hiding this comment.
Like we were discussing offline, even though our CFG2 has version as 6, I am wondering if it may not be safe to change default value to 7 until these changes are rolled out!
| BlobProperties blobProperties = blobInfo.getBlobProperties(); | ||
| boolean isSimpleBlob = !options.isChunkUpload() && !options.skipCompositeChunk(); | ||
| //Chunk upload does not need the customized blobId | ||
| BlobId.BlobDataType blobDataType = isSimpleBlob ? BlobId.BlobDataType.SIMPLE : BlobId.BlobDataType.METADATA; |
There was a problem hiding this comment.
Hmm.. I think we won't know if it is a "simple blob" or "composite blob" until we read data from Netty. Once we cross 4 MB, it becomes composite blob https://github.com/linkedin/ambry/blob/master/ambry-router/src/main/java/com/github/ambry/router/PutOperation.java#L688. I am wondering if we need to exclude this field as well during Ambry ID -> Caspian ID mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.